[webkit-reviews] review granted: [Bug 99904] [chromium] introduce a public API for the TestRunner library : [Attachment 169789] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 99904: [chromium] introduce a public API for the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99904

Attachment 169789: Patch
https://bugs.webkit.org/attachment.cgi?id=169789&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169789&action=review


> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:128
> +    m_internal = new Internal;

We should use WebPrivateOwnPtr here to help us avoid leaking.  We still need to
call reset manually, but at least there will be an ASSERT if we screw up.