[webkit-reviews] review granted: [Bug 99658] Crash when trying to write exception message to null console : [Attachment 169745] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 19 23:52:16 PDT 2012


Adam Barth <abarth at webkit.org> has granted  review:
Bug 99658: Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658

Attachment 169745: Patch
https://bugs.webkit.org/attachment.cgi?id=169745&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169745&action=review


Ok.  this makes sense.	Thanks for writing the test case.  The test case is
kind of nutty, but I guess that's needed since the bug is inherently racy.

>> LayoutTests/fast/workers/worker-exception-during-navigation.html:32
>> +	for (var i = 0; i< 500; i++) {
> 
> 500 workers!	Oh my.

Also, we're missing a space before the <


More information about the webkit-reviews mailing list