[webkit-reviews] review requested: [Bug 99850] [EFL][WK2] Use the port independent PageViewportController : [Attachment 169748] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 19 19:46:30 PDT 2012


Yael <yael.aharon.m at gmail.com> has asked  for review:
Bug 99850: [EFL][WK2] Use the port independent PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=99850

Attachment 169748: Patch
https://bugs.webkit.org/attachment.cgi?id=169748&action=review

------- Additional Comments from Yael <yael.aharon.m at gmail.com>
Take PageViewportController into use, and rely on it to calculate  scroll
position and zoom level. With this patch, we can do intra page navigation and
use the scrollwheel to scroll, when WTF_USE_COORDINATED_GRAPHICS and all
related flags are enabled.

With this patch touch events are broken since they do not yet take the scale
into account (They work only with scale = 1.0)
Also, mouse events do not work after scrolling.
There is no impact when WTF_USE_COORDINATED_GRAPHICS is turned off, and I am
still working on these issues, but would like to start the review going.


More information about the webkit-reviews mailing list