[webkit-reviews] review granted: [Bug 99890] Fix a hang when combining tile cache layers with preserve-3d or reflections : [Attachment 169728] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 99890: Fix a hang when combining tile cache layers with preserve-3d or
reflections
https://bugs.webkit.org/show_bug.cgi?id=99890

Attachment 169728: Patch
https://bugs.webkit.org/attachment.cgi?id=169728&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169728&action=review


I might like to see the changelog describe why preserve-3d and reflection
layers hit this.

> Source/WebCore/ChangeLog:15
> +	   on the fact that this flag-dirtying functions get called before the
later functions

typo this->these

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1445
> -	       // Update the properties of m_layer now that we no longer have a
structural layer.
> -	       updateGeometry(pageScaleFactor, positionRelativeToBase);
> -	       updateTransform();
> -	       updateChildrenTransform();
> -	       
> +	       m_uncommittedChanges |= NameChanged
> +		   | GeometryChanged
> +		   | TransformChanged
> +		   | ChildrenTransformChanged
> +		   | ChildrenChanged
> +		   | BackfaceVisibilityChanged

BackfaceVisibility wasn't here before the change. Is this right? Probably a
mistake that it wasn't :)