[webkit-reviews] review requested: [Bug 99864] Add a main resource type to the memory cache : [Attachment 169707] Address abarth's comments

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 99864: Add a main resource type to the memory cache
https://bugs.webkit.org/show_bug.cgi?id=99864

Attachment 169707: Address abarth's comments
https://bugs.webkit.org/attachment.cgi?id=169707&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
In the interest of simplification, I changed the cancel() call in
SubresourceLoader::willSendRequest() to be a regular cancel, rather than using
a custom ResourceError type.

I don't think that error was particularly meaningful, as it's the result of
MainResourceLoader calling PolicyChecker::checkNavigationPolicy() with a null
ResourceRequest.  It might as well be a general cancellation, as that's
effectively what the WebKit layer is doing by nulling out a ResourceRequest. 
That will mean one more test with changing expectations when this code comes
into use.