[webkit-reviews] review denied: [Bug 99870] Incorrect pattern scaling : [Attachment 169704] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 15:14:48 PDT 2012
Dirk Schulze <krit at webkit.org> has denied Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 99870: Incorrect pattern scaling
https://bugs.webkit.org/show_bug.cgi?id=99870
Attachment 169704: Patch
https://bugs.webkit.org/attachment.cgi?id=169704&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169704&action=review
> Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:131
> + patternData->transform.scale(tileBoundaries.width() /
tileImageSize.width(), tileBoundaries.height() / tileImageSize.height());
I can't really tell if that is fully correct, even if it looks sane. I would
like to have an easy example where you can see the wrong scaling behavior (sth.
with red wrong, just green correct).
More information about the webkit-reviews
mailing list