[webkit-reviews] review denied: [Bug 99780] [Chromium] Allow pushState and related history APIs to be disabled per context : [Attachment 169685] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 99780: [Chromium] Allow pushState and related history APIs to be disabled
per context
https://bugs.webkit.org/show_bug.cgi?id=99780

Attachment 169685: Patch
https://bugs.webkit.org/attachment.cgi?id=169685&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169685&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3438
> -    if (IsNodeSubType($dataNode) || $interfaceName eq "NotificationCenter")
{
> +    if (IsNodeSubType($dataNode) || $interfaceName eq "NotificationCenter"
|| $interfaceName eq "History") {

Please don't do this.  We're getting rid of this argument.  I'm just waiting
for the v8-team to make an API change.