[webkit-reviews] review granted: [Bug 99806] Use tile caches in place of CATiledLayer : [Attachment 169548] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 19 13:22:08 PDT 2012


Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 99806: Use tile caches in place of CATiledLayer
https://bugs.webkit.org/show_bug.cgi?id=99806

Attachment 169548: Patch
https://bugs.webkit.org/attachment.cgi?id=169548&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169548&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1561
> +    float leftEdgeDelta = paddingMultiplier * (m_visibleRect.x() -
oldVisibleRect.x());

We should consider doing this for the main tile cache too.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-2504
> -    m_layer = PlatformCALayer::create(useTiledLayer ?
PlatformCALayer::LayerTypeWebTiledLayer : PlatformCALayer::LayerTypeWebLayer,
this);

Can we disappear LayerTypeWebTiledLayer entirely?


More information about the webkit-reviews mailing list