[webkit-reviews] review granted: [Bug 99768] We should limit the tile cache coverage when a page can't take advantage of fast tile scrolling anyway : [Attachment 169521] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 99768: We should limit the tile cache coverage when a page can't take
advantage of fast tile scrolling anyway
https://bugs.webkit.org/show_bug.cgi?id=99768

Attachment 169521: Patch
https://bugs.webkit.org/attachment.cgi?id=169521&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169521&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:282
> +MainThreadScrollingReasons
ScrollingCoordinator::shouldUpdateScrollLayerPositionOnMainThread() const

Returning the MainThreadScrollingReasons from a 'should' method is a bit
confusing; I think this would be clearer as two methods (possibly inline):

MainThreadScrollingReasons mainThreadScrollingReasons() const;
bool shouldUpdateScrollLayerPositionOnMainThread() const { return
mainThreadScrollingReasons() != 0; }