[webkit-reviews] review granted: [Bug 99863] [chromium] API to pass impl thread via WebLayerTreeView : [Attachment 169675] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 99863: [chromium] API to pass impl thread via WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=99863

Attachment 169675: Patch
https://bugs.webkit.org/attachment.cgi?id=169675&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169675&action=review


This looks great.

> Source/Platform/chromium/public/WebLayerTreeView.h:75
> +    WEBKIT_EXPORT static WebLayerTreeView* create(WebLayerTreeViewClient*,
const WebLayer& root, const Settings&, WebThread* implThread);
> +    // FIXME(aelias): Delete this version when the above is implemented.
>      WEBKIT_EXPORT static WebLayerTreeView* create(WebLayerTreeViewClient*,
const WebLayer& root, const Settings&);

Actually both of these ::create()s are dead - in fact all of the ::create()
functions for things that hang off of WebCompositorSupport are currently
unimplemented and uncalled.  I still haven't deleted them because I suck :(. 
Don't worry about patching this file