[webkit-reviews] review granted: [Bug 99804] Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT : [Attachment 169571] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Dongwoo Joshua Im (dwim)
<dw.im at samsung.com>'s request for review:
Bug 99804: Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
https://bugs.webkit.org/show_bug.cgi?id=99804

Attachment 169571: Patch
https://bugs.webkit.org/attachment.cgi?id=169571&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169571&action=review


> Interesting, I've applied your patch locally and then ran
'check-webkit-style' which shows 0 errors. Is this an issue from the style
build bot itself?

Linting errors are usually resolved fast as they turn the bots red so the patch
probably hit a bad revision. Note that you can check linting errors with
new-run-webkit-tests --lint-test-files (which is run as part of
check-webkit-style).

> LayoutTests/platform/qt-mac/TestExpectations:5808
> +# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
>  webkit.org/b/58491 fast/css3-text-decoration

The error is line 1521 per the style bot so it's unrelated as you only touching
around line 5808.