[webkit-reviews] review granted: [Bug 99805] Add Stack statistics collection mechanism : [Attachment 169552] Fix.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 99805: Add Stack statistics collection mechanism
https://bugs.webkit.org/show_bug.cgi?id=99805

Attachment 169552: Fix.
https://bugs.webkit.org/attachment.cgi?id=169552&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169552&action=review


Please remove the change to Options.cpp.

> Source/WTF/wtf/StackStats.cpp:43
> +FILE* StackStats::s_logFile = 0;

Can we use dataLog() instead?

> Source/WTF/wtf/StackStats.cpp:60
> +#define STACK_STATS_LOG_FILE "/tmp/stack-stats.log"

We typically prefer "static const char* const" vs macro.

> Source/WTF/wtf/StackStats.cpp:312
> +	   fprintf(log, " LAYOUT %p diff %d/%.1fk/max %.1fk | reentry %d/max %d
| height %.1fk/max %.1fk | stack %p size %.1fk\n",

and here too