[webkit-reviews] review granted: [Bug 99831] [Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active : [Attachment 169618] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 99831: [Qt][WTR] renderToOffscreenBuffer should not be set if the real
render loop is active
https://bugs.webkit.org/show_bug.cgi?id=99831

Attachment 169618: Patch
https://bugs.webkit.org/attachment.cgi?id=169618&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169618&action=review


> Source/WebKit2/ChangeLog:8
> +	   Update the comment about renderToOffscreenBuffer to better describe
it's role.

it's -> its

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:445
> +	   // This can the case when running tests. See
WTR::PlatformWebView::windowShapshotEnabled.

I'm not sure what this line adds, there's a "be" missing, "when running tests"
is repeated from above and windowShapshotEnabled is only indirectly related.