[webkit-reviews] review granted: [Bug 99820] REGRESSION(r131844): It broke the build on !ENABLE(NETSCAPE_PLUGIN_API) platforms : [Attachment 169582] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 02:41:05 PDT 2012
Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 99820: REGRESSION(r131844): It broke the build on
!ENABLE(NETSCAPE_PLUGIN_API) platforms
https://bugs.webkit.org/show_bug.cgi?id=99820
Attachment 169582: Patch
https://bugs.webkit.org/attachment.cgi?id=169582&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169582&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1321
> +#if PLATFORM(MAC) || ENABLE(NETSCAPE_PLUGIN_API)
> WebPage* webPage = m_frame->page();
> ASSERT(webPage);
> -
> +#endif
Nitpick: we could also use m_frame->page() directly to call layerHostingMode
and createPlugin.
More information about the webkit-reviews
mailing list