[webkit-reviews] review denied: [Bug 99744] [Qt] Get rid of QQuickWebView::setRenderToOffscreenBuffer : [Attachment 169447] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 01:39:06 PDT 2012
Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 99744: [Qt] Get rid of QQuickWebView::setRenderToOffscreenBuffer
https://bugs.webkit.org/show_bug.cgi?id=99744
Attachment 169447: Patch
https://bugs.webkit.org/attachment.cgi?id=169447&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
See https://bugs.webkit.org/show_bug.cgi?id=76708
This wasn't needed to get the pixels but to make sure that the rendering queue
in LayerTreeRenderer doesn't fill up when the window isn't shown. See that
we're still using a 1x1 image.
Since we only enable the rendering for pixel tests, I believe that we still
need that code for the rest.
More information about the webkit-reviews
mailing list