[webkit-reviews] review granted: [Bug 99793] make move_overwritten_baselines_to work again while rebaselining : [Attachment 169530] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 99793: make move_overwritten_baselines_to work again while rebaselining
https://bugs.webkit.org/show_bug.cgi?id=99793

Attachment 169530: Patch
https://bugs.webkit.org/attachment.cgi?id=169530&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169530&action=review


> Tools/Scripts/webkitpy/layout_tests/port/builders.py:44
> +#	  FIXME: When do you need this?

This is a workaround for ports that don't have full bot coverage, e.g. win-7sp1
actualy corresponds to platform/win, but there's no win-7sp1 bot, so we hack
the win-7sp0 bot to put baselines in platform/win and qt-linux is th eonly qt
bot on the webkit.org waterfall to run tests. I'm not sure at the moment, why
mac-mountainlion needs this though. That might be a bug.

It's a total hack. Not sure what else we could do. I suppose we could try to
encourage ports to get better coverage, except platform/qt is like
platform/chromium (i.e. there's no such thing as a plain qt bot). So they would
need full coverage for every platform/qt-* directory before we could remove it
for them.

There's probably a better way to do all this, but it hasn't yet occurred to me.
:)