[webkit-reviews] review granted: [Bug 99787] Add shortMonthLabels and shortStandAloneMonthLabels to Localizer : [Attachment 169544] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 99787: Add shortMonthLabels and shortStandAloneMonthLabels to Localizer
https://bugs.webkit.org/show_bug.cgi?id=99787

Attachment 169544: Patch
https://bugs.webkit.org/attachment.cgi?id=169544&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169544&action=review


> Source/WebCore/platform/text/LocaleICU.cpp:466
> +	       m_shortStandAloneMonthLabels = *labels;

Nit: I would prefer early return here. 'return m_shortStandAloneMonthLabels;'

> Source/WebCore/platform/text/LocaleICU.cpp:468
> +    if (m_shortStandAloneMonthLabels.isEmpty())

Then you can remove this branch.

> Source/WebCore/platform/text/LocaleNone.cpp:99
> +    m_shortMonthLabels.reserveCapacity(12);

Nit: 12 => WTF_ARRAY_LENGTH(WTF::monthName)