[webkit-reviews] review granted: [Bug 99798] Clean up RegExpKey : [Attachment 169538] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 99798: Clean up RegExpKey
https://bugs.webkit.org/show_bug.cgi?id=99798

Attachment 169538: Patch
https://bugs.webkit.org/attachment.cgi?id=169538&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169538&action=review


> Source/JavaScriptCore/ChangeLog:10
> +	   RegExpHash doesn't need to be a class template specialization when
the class template is specialized
> +	   for JSC::RegExpKey only. Make it a nested class of RegExp instead.
Also, make operator== a friend function
> +	   and move it inside the class.

Making friend function seems good to me. Moving inside the class does not seem
good to me. I find class definitions easier to read when they don’t have long
function definitions inside them.