[webkit-reviews] review granted: [Bug 99771] [WK2] Safari does not build without PLUGIN_PROCESS : [Attachment 169504] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 99771: [WK2] Safari does not build without PLUGIN_PROCESS
https://bugs.webkit.org/show_bug.cgi?id=99771

Attachment 169504: Patch
https://bugs.webkit.org/attachment.cgi?id=169504&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169504&action=review


> Source/WebKit2/Platform/CoreIPC/MessageID.h:115
> +#if ENABLE(PLUGIN_PROCESS)
>      // Messages sent by the UI process to the shared worker process.
>      MessageClassSharedWorkerProcess,
> +#endif // ENABLE(PLUGIN_PROCESS)

I think this should be ENABLE(SHARED_WORKER_PROCESS).

> Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h:51
>	   PluginProcess,

Maybe PluginProcess should be surrounded with #ifdefs too.