[webkit-reviews] review granted: [Bug 99783] [V8] fast/dom/gc-9.html fails for document.implementation : [Attachment 169523] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 18:06:08 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 99783: [V8] fast/dom/gc-9.html fails for document.implementation
https://bugs.webkit.org/show_bug.cgi?id=99783

Attachment 169523: Patch
https://bugs.webkit.org/attachment.cgi?id=169523&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169523&action=review


Looks reasonable.

> LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:8
> +PASS: document.implementation.myCustomProperty should be 1 and is.

Looks fine.

> LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:49
> +FAIL:
document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty
should be 1 but instead is undefined.

Just a confirmation: Are a bunch of FAIL lines in the expected result intended?


More information about the webkit-reviews mailing list