[webkit-reviews] review granted: [Bug 99772] [chromium] include WebTestingSupport in the webkit target : [Attachment 169517] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 17:46:34 PDT 2012


Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 99772: [chromium] include WebTestingSupport in the webkit target
https://bugs.webkit.org/show_bug.cgi?id=99772

Attachment 169517: Patch
https://bugs.webkit.org/attachment.cgi?id=169517&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169517&action=review


We could alos make this a dependency of TestRunner once we build that as a
separate lib.

> Source/WebKit/chromium/WebKit.gyp:876
> +		   # WARNING: Do not view this particular case as a precedent
for
> +		   # including WebCore headers in DumpRenderTree project.

This warning seems unneeded now.


More information about the webkit-reviews mailing list