[webkit-reviews] review denied: [Bug 99770] Mac WTF build checks dependencies before copying header files : [Attachment 169509] Fixed a couple of problems from original checkin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 17:24:11 PDT 2012


Mark Rowe (bdash) <mrowe at apple.com> has denied Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 99770: Mac WTF build checks dependencies before copying header files
https://bugs.webkit.org/show_bug.cgi?id=99770

Attachment 169509: Fixed a couple of problems from original checkin
https://bugs.webkit.org/attachment.cgi?id=169509&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Beyond this, you should create a new CopyWTFHeaders.xcconfig file for this
target and move the bits that this target needs that the WTF no longer needs
(PRIVATE_HEADERS_FOLDER_PATH / INSTALLHDRS_SCRIPT_PHASE, I think) out of
WTF.xcconfig. If you do that as well then I think that'll address all of my
complaints.


More information about the webkit-reviews mailing list