[webkit-reviews] review granted: [Bug 98787] AX: aria-hidden=false does not work as expected : [Attachment 169049] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 16:57:29 PDT 2012


Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 98787: AX: aria-hidden=false does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=98787

Attachment 169049: patch
https://bugs.webkit.org/attachment.cgi?id=169049&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169049&action=review


> Source/WebCore/accessibility/AXObjectCache.cpp:793
> +bool isNodeAriaHiddenFalse(Node* node)

It would be a bit nicer to name this isNodeAriaHidden() and then just test
!isNodeAriaHidden() when you want to know if it is false.


More information about the webkit-reviews mailing list