[webkit-reviews] review granted: [Bug 99706] MIPS LLInt implementation. : [Attachment 169392] LLInt implementation for MIPS.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Balazs Kilvady
<kilvadyb at homejinni.com>'s request for review:
Bug 99706: MIPS LLInt implementation.
https://bugs.webkit.org/show_bug.cgi?id=99706

Attachment 169392: LLInt implementation for MIPS.
https://bugs.webkit.org/attachment.cgi?id=169392&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169392&action=review


r=me, but it would be nice if you could respond to my comments :D

> Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:126
> +    ".set noreorder\n" \

Quick question, what does this do?  Disable instruction reordering, or disable
function reordering - LLInt should be safe against function reordering so if
it's the latter this is probably unnecessary.  If it's not then just ignore me
:D

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:163
> +	   move sourceRegister, lr

I feel that we should just have 
if C_LOOP or ARMv7 or MIPS
    move sourceRegister, lr
elsif X86 or X86_64
     ...
else
    error
end