[webkit-reviews] review granted: [Bug 99704] Add Localizer::monthFormat and implementations : [Attachment 169388] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 99704: Add Localizer::monthFormat and implementations
https://bugs.webkit.org/show_bug.cgi?id=99704

Attachment 169388: Patch
https://bugs.webkit.org/attachment.cgi?id=169388&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169388&action=review


> Source/WebCore/platform/text/LocaleWin.cpp:720
> +    m_monthFormat =
convertWindowsDateFormatToLDML(parseDateFormat(getLocaleInfoString(LOCALE_SYEAR
MONTH)));

(I don't know the details but) don't you need to use m_locale instead of
LOCALE_SYEARMONTH?

> Source/WebKit/chromium/tests/LocaleMacTest.cpp:247
> +    EXPECT_STREQ("MMM yyyy", monthFormat("en_US").utf8().data());

Nit: Shall we add a test case for French, just like other tests?