[webkit-reviews] review granted: [Bug 96784] [GTK] Don't use the C API internally in WebKitSettings : [Attachment 168891] Updated patch to build on current git master
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 18 06:25:00 PDT 2012
Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 96784: [GTK] Don't use the C API internally in WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=96784
Attachment 168891: Updated patch to build on current git master
https://bugs.webkit.org/attachment.cgi?id=168891&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168891&action=review
> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:-1105
> - ASSERT(!priv->userAgent.isNull());
Shouldn't you keep the ASSERT?
More information about the webkit-reviews
mailing list