[webkit-reviews] review requested: [Bug 99697] [EFL][WK2] Use pimpl idiom for Ewk_Download_Job : [Attachment 169395] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 18 05:14:23 PDT 2012
Christophe Dumez <christophe.dumez at intel.com> has asked for review:
Bug 99697: [EFL][WK2] Use pimpl idiom for Ewk_Download_Job
https://bugs.webkit.org/show_bug.cgi?id=99697
Attachment 169395: Patch
https://bugs.webkit.org/attachment.cgi?id=169395&action=review
------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Mikhail and I made another iteration of the patch so we are requesting r?
again.
The improvement is that the pimpl data pointer is now private (it used to be
public). The drawback is that we need an additional EWK_DECLARE_DATA_OWNER()
macro for the Data type.
More information about the webkit-reviews
mailing list