[webkit-reviews] review granted: [Bug 99697] [EFL][WK2] Use pimpl idiom for Ewk_Download_Job : [Attachment 169367] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 99697: [EFL][WK2] Use pimpl idiom for Ewk_Download_Job
https://bugs.webkit.org/show_bug.cgi?id=99697

Attachment 169367: Patch
https://bugs.webkit.org/attachment.cgi?id=169367&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169367&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp:47
> +    uint64_t downloaded; /**< length already downloaded */

why not just use C++ comments

> Source/WebKit2/UIProcess/API/efl/ewk_private.h:45
> +// Macros used for Pimpl idiom.
> +#define EWK_DECLARE_DATA(ClassName) struct Data; OwnPtr<Data> d
> +#define EWK_D(ClassName, obj) ClassName::Data* d = obj->d.get()

Qt allows to get the owner as well, (d upside down, ie. q) :-)