[webkit-reviews] review denied: [Bug 91907] Implement setRangeText() on text controls : [Attachment 169341] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 00:17:01 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 91907: Implement setRangeText() on text controls
https://bugs.webkit.org/show_bug.cgi?id=91907

Attachment 169341: Patch
https://bugs.webkit.org/attachment.cgi?id=169341&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169341&action=review


> LayoutTests/fast/forms/datetimelocal/datetimelocal-setrangetext.html:11
> +runTestsShouldFail("input", { type: "datetimelocal" });

should be
    type: "datetime-local"

> LayoutTests/fast/forms/time/time-setrangetext.html:10
> +description("Test setRangeText() method rs not available in time inputs.");

rs -> is


More information about the webkit-reviews mailing list