[webkit-reviews] review denied: [Bug 91907] Implement setRangeText() on text controls : [Attachment 169309] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 91907: Implement setRangeText() on text controls
https://bugs.webkit.org/show_bug.cgi?id=91907

Attachment 169309: Patch
https://bugs.webkit.org/attachment.cgi?id=169309&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169309&action=review


> LayoutTests/fast/forms/color/color-setrangetext-expected.txt:11
> +element.value = '0123456789XYZ'
> +PASS element.setRangeText('ABC', 0, 0) threw exception Error:
INVALID_STATE_ERR: DOM Exception 11.
> +PASS element.value is "0123456789XYZ"

Because input[type=color] sanitizes the value, element.value should be
"#000000"

> LayoutTests/fast/forms/datalist/datalist-setrangetext.html:11
> +runTestsShouldFail("input", { type: "datalist" });

datalist is not an input type.	You don't need add a test.

> LayoutTests/fast/forms/date/date-setrangetext-expected.txt:11
> +PASS element.value is "0123456789XYZ"

element.value should be "" because of value sanitization.

> LayoutTests/fast/forms/datetime/datetime-setrangetext-expected.txt:11
> +PASS element.value is "0123456789XYZ"

element.value should be "" because of value sanitization.

>
LayoutTests/fast/forms/datetimelocal/datetimelocal-setrangetext-expected.txt:11

> +PASS element.value is "0123456789XYZ"

element.value should be "" because of value sanitization.

> LayoutTests/fast/forms/month/month-setrangetext-expected.txt:11
> +PASS element.value is "0123456789XYZ"

element.value should be "" because of value sanitization.

> LayoutTests/fast/forms/time/time-setrangetext-expected.txt:11
> +PASS element.value is "0123456789XYZ"

element.value should be "" because of value sanitization.

> LayoutTests/fast/forms/week/week-setrangetext-expected.txt:11
> +PASS element.value is "0123456789XYZ"

element.value should be "" because of value sanitization.