[webkit-reviews] review denied: [Bug 99647] HTMLMediaPlayer should free m_player on error. : [Attachment 169278] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 99647: HTMLMediaPlayer should free m_player on error.
https://bugs.webkit.org/show_bug.cgi?id=99647

Attachment 169278: Patch
https://bugs.webkit.org/attachment.cgi?id=169278&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169278&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:4324
> +    if (event->type() == eventNames().errorEvent)
> +	   m_player = nullptr;

An error event doesn't mean that the media player doesn't have any valid data,
eg. losing the connection to the server will fire an error event with some
media engines. This will change will *always* delete the media player and lose
all state.