[webkit-reviews] review granted: [Bug 99646] Use virtual dispatch to create ContentData renderers : [Attachment 169277] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 17 15:43:43 PDT 2012
Eric Seidel <eric at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 99646: Use virtual dispatch to create ContentData renderers
https://bugs.webkit.org/show_bug.cgi?id=99646
Attachment 169277: Patch
https://bugs.webkit.org/attachment.cgi?id=169277&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169277&action=review
LGTM.
> Source/WebCore/rendering/style/ContentData.cpp:88
> + RenderObject* renderer = new (doc->renderArena()) RenderTextFragment(doc
/* anonymous object */, m_text.impl());
I don't think the /* anonymous object */ comment is particularly helpful.
More information about the webkit-reviews
mailing list