[webkit-reviews] review granted: [Bug 99520] Context menu generated from touch gestures on textareas has context of the cursor position instead of the position where the event occurs. : [Attachment 169241] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 99520: Context menu generated from touch gestures on textareas has context
of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520

Attachment 169241: Patch
https://bugs.webkit.org/attachment.cgi?id=169241&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169241&action=review


Please fix my comments before landing

> Source/WebKit/chromium/ChangeLog:13
> +	   * src/WebViewImpl.cpp:
> +	   (WebKit::WebViewImpl::handleGestureEvent):

I would write that you are now using the same code path as
WebInputEvent::GestureLongPress

> Source/WebCore/page/EventHandler.cpp:2799
> +    handleMousePressEvent(mouseEvent);

I would add a comment why mouse release it not needed

>
LayoutTests/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correc
t-position.html:7
> +This test checks that on long press gesture in a text area, the cursor is

or two finger?