[webkit-reviews] review denied: [Bug 99248] [BlackBerry] Adapt to Platform API changes in string handling : [Attachment 168583] Follow-on patch to change m_mode to AtomicString

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 14:46:21 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has denied George Staikos
<staikos at kde.org>'s request for review:
Bug 99248: [BlackBerry] Adapt to Platform API changes in string handling
https://bugs.webkit.org/show_bug.cgi?id=99248

Attachment 168583: Follow-on patch to change m_mode to AtomicString
https://bugs.webkit.org/attachment.cgi?id=168583&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168583&action=review


You should change setMode() and mode() accordingly.

> Source/WebCore/ChangeLog:4
> +	   Conert m_mode to be an AtomicString.
> +	   https://bugs.webkit.org/show_bug.cgi?id=99248

Conert -> Convert.
This should have its own bug in bugzilla.


More information about the webkit-reviews mailing list