[webkit-reviews] review granted: [Bug 84657] Crash or assertion failure (m_isAnimating) when adding another instance of a SMIL animated element while the animation is running : [Attachment 169101] Allow lazy initialization of SVG XML animated properties.

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 84657: Crash or assertion failure (m_isAnimating) when adding another
instance of a SMIL animated element while the animation is running
https://bugs.webkit.org/show_bug.cgi?id=84657

Attachment 169101: Allow lazy initialization of SVG XML animated properties.
https://bugs.webkit.org/attachment.cgi?id=169101&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169101&action=review


> LayoutTests/svg/animations/use-while-animating-crash.html:23
> +	       }, 20); // This needs to be at least 20 to ensure an animation
cycle runs.

Do we not have a better way to do this? Events we can watch, or something? I
cringe every time I see a non-0 setTimeout in a layout test.