[webkit-reviews] review denied: [Bug 99150] [BlackBerry] Dump DRT output to stdout if test is passed as command line argument : [Attachment 168614] patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 99150: [BlackBerry] Dump DRT output to stdout if test is passed as command
line argument
https://bugs.webkit.org/show_bug.cgi?id=99150

Attachment 168614: patch
https://bugs.webkit.org/attachment.cgi?id=168614&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168614&action=review


Patch is ok, but runFromCommandLine functionality should be put into a
function.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:224
> +    if (runFromCommandLine) {

I talked with Ming and we think it is nicer if this is a method instead, which
does the getenv internally.