[webkit-reviews] review granted: [Bug 99529] GraphicsLayer visible rect computation needs to use the current animating transform : [Attachment 169067] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 99529: GraphicsLayer visible rect computation needs to use the current
animating transform
https://bugs.webkit.org/show_bug.cgi?id=99529

Attachment 169067: Patch
https://bugs.webkit.org/attachment.cgi?id=169067&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169067&action=review


> Source/WebCore/platform/graphics/GraphicsLayerClient.h:75
> +    virtual void currentTransform(const GraphicsLayer*,
TransformationMatrix&) const { }

It's a bit strange that this method is called currentTransform like the
existing method on RenderLayer, but modifies its parameter rather than
providing a return value.

> Source/WebCore/rendering/RenderLayer.h:598
> -    TransformationMatrix currentTransform() const;
> +    TransformationMatrix currentTransform(RenderStyle::ApplyTransformOrigin
= RenderStyle::IncludeTransformOrigin) const;

This is the existing one (in another class)

> Source/WebCore/rendering/RenderLayerBacking.h:151
> +    virtual void currentTransform(const GraphicsLayer*,
TransformationMatrix&) const;

This is the new one.

> LayoutTests/compositing/visible-rect/animated.html:26
> +	   @-webkit-keyframes move {
> +	       from { -webkit-transform: translateX(-100px); }
> +	       to   { -webkit-transform: translateX(300px); }
> +	   }

I'm not sure how this test is exercising the new code. You don't have anything
here that setting transform origin.