[webkit-reviews] review denied: [Bug 99449] WebPageProxy::canShowMIMEType() should return false for plugins when they are disabled or blocked : [Attachment 168915] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 10:55:37 PDT 2012


Anders Carlsson <andersca at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 99449: WebPageProxy::canShowMIMEType() should return false for plugins when
they are disabled or blocked
https://bugs.webkit.org/show_bug.cgi?id=99449

Attachment 168915: Patch
https://bugs.webkit.org/attachment.cgi?id=168915&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
I don't think the shouldBlockPlugin check is correct here. We should try (and
fail) to load the plug-in when it's blocked. Please remove that check.


More information about the webkit-reviews mailing list