[webkit-reviews] review denied: [Bug 99232] Content element does not expose distributedNodes property : [Attachment 169159] Call updateLayout() explicitly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 10:10:57 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 99232: Content element does not expose distributedNodes property
https://bugs.webkit.org/show_bug.cgi?id=99232

Attachment 169159: Call updateLayout() explicitly.
https://bugs.webkit.org/attachment.cgi?id=169159&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169159&action=review


> Source/WebCore/html/shadow/HTMLContentElement.idl:33
> +    NodeList distributedNodes();

I don't understand why this is a method? It should be an attribute, just like
Node.childNodes or MutationRecord.addedNodes/removedNodes. We may want to
optimize not to re-create the array on each access though.


More information about the webkit-reviews mailing list