[webkit-reviews] review granted: [Bug 99582] Bind isolatedWorldSecurityOrigin to world : [Attachment 169153] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 99582: Bind isolatedWorldSecurityOrigin to world
https://bugs.webkit.org/show_bug.cgi?id=99582

Attachment 169153: Patch
https://bugs.webkit.org/attachment.cgi?id=169153&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169153&action=review


This has the effect of making the security origin for isolated worlds global
rather than per-frame.	That seems like what the embedder would want.

I presume the next step is to store this information in DOMWrapperWorld
directly rather than using a hash map.

> LayoutTests/http/tests/security/isolatedWorld/cross-origin-xhr.html:51
> +				       
testRunner.setIsolatedWorldSecurityOrigin(1, null);
> +				       
testRunner.setIsolatedWorldSecurityOrigin(2, null);

Looks like you've got a bad indent here.  Please use spaces rather than tabs.