[webkit-reviews] review granted: [Bug 99558] [gyp] fix bundle resources for DumpRenderTree on mac : [Attachment 169108] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 17 08:44:19 PDT 2012
Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 99558: [gyp] fix bundle resources for DumpRenderTree on mac
https://bugs.webkit.org/show_bug.cgi?id=99558
Attachment 169108: Patch
https://bugs.webkit.org/attachment.cgi?id=169108&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks reasonable to me. Should we have a build step somewhere that checks
that we don't leak these resources into Chrome.app? I guess Chrome.app
shouldn't depend on TestRunner_resources...
Ideally thakis and/or tony^work would comment before we land this patch.
More information about the webkit-reviews
mailing list