[webkit-reviews] review granted: [Bug 98366] [GTK] accessibility/ignore-spacer-elements.html is failing : [Attachment 169157] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 08:22:32 PDT 2012


chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 98366: [GTK] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98366

Attachment 169157: Patch
https://bugs.webkit.org/attachment.cgi?id=169157&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169157&action=review


> LayoutTests/accessibility/ignore-spacer-elements.html:29
> +	       if (container.childrenCount == expectedCount) {

this is a pretty bad test that only outputs Test passed with no indication of
what might have failed. We should log a bug to rewrite it so it's a little more
descriptive


More information about the webkit-reviews mailing list