[webkit-reviews] review denied: [Bug 99457] Web Inspector: NMI provide data for mixing with tcmalloc heap dumps : [Attachment 168932] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 08:08:55 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 99457: Web Inspector: NMI provide data for mixing with tcmalloc heap dumps
https://bugs.webkit.org/show_bug.cgi?id=99457

Attachment 168932: Patch
https://bugs.webkit.org/attachment.cgi?id=168932&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168932&action=review


> Source/WebKit/chromium/public/WebDevToolsAgentClient.h:66
> +	   virtual size_t visitObject(const void* ptr) = 0;

Please use separate interface for this.


More information about the webkit-reviews mailing list