[webkit-reviews] review granted: [Bug 96769] [GTK] Don't use the C API internally in WebKitBackForwardList : [Attachment 166481] Updated patch to apply on current git master

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 96769: [GTK] Don't use the C API internally in WebKitBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=96769

Attachment 166481: Updated patch to apply on current git master
https://bugs.webkit.org/attachment.cgi?id=166481&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review


>>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
>>> +	 WebBackForwardList* webList;
>> 
>> I would probably name it backForwardList instead of webList. But I'm not
genius choosing names either, so take it as a subjective opinion.
> 
> This was wkList before, I think, I renamed to webList to avoid confusion with
C API variables.

How about naming it items or backForwardItems? backForwardList is a bad name I
think because it's the name of the object that holds this private structure in
most cases. This is the list of backForwardItems.