[webkit-reviews] review requested: [Bug 99492] [WK2][GTK] Favicons are incorrectly released before receiving the actual data : [Attachment 169155] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 99492: [WK2][GTK] Favicons are incorrectly released before receiving the
actual data
https://bugs.webkit.org/show_bug.cgi?id=99492

Attachment 169155: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=169155&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #5)
> (From update of attachment 169117 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=169117&action=review
> 
> I'm still worried that the idle thing works in some cases only, because in
the end
> you don't know when the idle will be called. So, since what we want is to
release
> the icons when we are sure, and after finish, I think we could schedule the
idle
> when the data struct finishes or even do it in the async data struct
destructor
> directly. We retain the icon in get_favicon() right before calling
> getIconSurfaceSynchronously(). if we don't have an icon we mark the icon to
be
> released (with a bool parameter in the async data struct, for example). If we

> eventually get an icon in processPendingIconRequests we set the flag to
false. In
> the async data destrcutor we check the flag and release the icon (or schedule
a
> release in an idle).

Ok. I'm attaching now a new patch implementing this (third) new approach :)