[webkit-reviews] review granted: [Bug 76219] cairo_t* memory leak in GraphicsContext::platformInit : [Attachment 169104] Proposal for fixing the memory leak in WinCairo
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 17 00:20:25 PDT 2012
Hideki <yoshida-hxa at necst.nec.co.jp> has granted review:
Bug 76219: cairo_t* memory leak in GraphicsContext::platformInit
https://bugs.webkit.org/show_bug.cgi?id=76219
Attachment 169104: Proposal for fixing the memory leak in WinCairo
https://bugs.webkit.org/attachment.cgi?id=169104&action=review
------- Additional Comments from Hideki <yoshida-hxa at necst.nec.co.jp>
Thank you for useful information, Brain.
My team also found same memory leak problem in WinCairo port and
figured out the same bug.
Here is the patch which we made.
We just moved
cairo_destroy(cr);
to the end of the function and added if statement to
make sure that cr is not ZERO for fear that createCairoContextWithHDC
is not called.
More information about the webkit-reviews
mailing list