[webkit-reviews] review denied: [Bug 98366] [GTK] accessibility/ignore-spacer-elements.html is failing : [Attachment 169059] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 16 22:15:29 PDT 2012


chris fleizach <cfleizach at apple.com> has denied Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 98366: [GTK] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98366

Attachment 169059: Patch
https://bugs.webkit.org/attachment.cgi?id=169059&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
It doesn't seem like we should remove the Failure keyword if the GTK expected
file says FAIL. 
There are a number of options (maybe more than this)
  a) Skip this test and add a copy of it just for GTK that has the right value
  b) add something in DRT to identify GTK builds and conditionalize the test
  c) change the output so that it doesn't just output childrenCount and instead
outputs something more meaningful


More information about the webkit-reviews mailing list