[webkit-reviews] review denied: [Bug 99537] Hide popup while transitioning from the suggestion picker to the calendar picker : [Attachment 169083] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 16 21:44:41 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 99537: Hide popup while transitioning from the suggestion picker to the
calendar picker
https://bugs.webkit.org/show_bug.cgi?id=99537

Attachment 169083: Patch
https://bugs.webkit.org/attachment.cgi?id=169083&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169083&action=review


>
LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appear
ance-step.html:8
> -    popupWindow.removeEventListener('resize', finishTest);
> +    popupWindow.removeEventListener('didOpenPicker', finishTest);

Would you apply a technique same as http://trac.webkit.org/changeset/131404 as
possible before this change please?


More information about the webkit-reviews mailing list