[webkit-reviews] review denied: [Bug 98337] [chromium] New WeRenderingStats for compositor frames : [Attachment 169068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 16 18:46:37 PDT 2012


James Robinson <jamesr at chromium.org> has denied Brian Anderson
<brianderson at chromium.org>'s request for review:
Bug 98337: [chromium] New WeRenderingStats for compositor frames
https://bugs.webkit.org/show_bug.cgi?id=98337

Attachment 169068: Patch
https://bugs.webkit.org/attachment.cgi?id=169068&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I don't think patching WebKit for this is needed - the produce and consumer of
these stats are on the chromium side, WebKit isn't adding any value.

If you need this quickly then I'd suggest patching the chromium side by adding
a subclass of WebRenderingStats that has the values you want and then
downcasting in src/webkit/compositor_bindings/WebLayerTreeViewImpl.cpp.  If you
aren't in a huge rush, once http://crbug.com/156175 gets resolved this'll be
less ugly.


More information about the webkit-reviews mailing list