[webkit-reviews] review granted: [Bug 99518] Create a GraphicsLayerUpdater class that will do periodic layer flushes for layer trees containing tile caches : [Attachment 169057] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 99518: Create a GraphicsLayerUpdater class that will do periodic layer
flushes for layer trees containing tile caches
https://bugs.webkit.org/show_bug.cgi?id=99518

Attachment 169057: Patch
https://bugs.webkit.org/attachment.cgi?id=169057&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169057&action=review


Shame we can't test any of this.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:6360
> +		FD315FFE12B0267600C1A359 /* ChannelMergerNode.cpp in Sources */
= {isa = PBXBuildFile; fileRef = FD315FB412B0267500C1A359 /*
ChannelMergerNode.cpp */; };

I'll just assume all these unrelated changes are ok - did you sort entries or
something?

> Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:41
> +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
> +    DisplayRefreshMonitorManager::sharedManager()->registerClient(this);
> +   
DisplayRefreshMonitorManager::sharedManager()->windowScreenDidChange(displayID,
this);
> +    DisplayRefreshMonitorManager::sharedManager()->scheduleAnimation(this);
> +#endif

So I guess other ports will have to implement their own GLUpdater machinery?

> Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:47
> +GraphicsLayerUpdater::~GraphicsLayerUpdater()
> +{
> +    // ~DisplayRefreshMonitorClient unregisters us as a client.
> +}

Is there ever a case where the GLU can go away before the DRMC does?

> Source/WebCore/platform/graphics/GraphicsLayerUpdater.h:35
> +class GraphicsLayer;

Not sure you need this.